Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIORGS-453: Enhancement settings help text #670

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

elsenhans
Copy link
Contributor

Purpose

https://folio-org.atlassian.net/browse/UIORGS-453

Addition to help text in the black banner at the top of “Settings > Organizations > Number generator options” to guide users to Settings > Service interaction for additional number generator settings

Please add to existing text:
Additional number generator settings are available under “Settings > Service interaction”. At “Settings > Service interaction > Number generator sequences” sequences can be defined by selecting the appropriate generator via the drop-down menu.

Please link
Settings > Service interaction --> (settings/service-interaction)
Settings > Service interaction > Number generator sequences --> (settings/service-interaction/numberGeneratorSequences/)

Screenshot

UIORGS-453

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@elsenhans elsenhans requested review from NikitaSedyx and a team January 10, 2025 11:37
Copy link

Jest Unit Test Statistics

    1 files  ±0    92 suites  ±0   2m 57s ⏱️ -15s
297 tests ±0  295 ✔️ ±0  2 💤 ±0  0 ±0 
301 runs  ±0  298 ✔️ ±0  3 💤 ±0  0 ±0 

Results for commit a344832. ± Comparison against base commit 1e8b5ea.

Copy link

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit a344832. ± Comparison against base commit 1e8b5ea.

@elsenhans
Copy link
Contributor Author

elsenhans commented Jan 14, 2025

@folio-org/acquisitions-ui Does a second reviewer wants to check this PR?

@NikitaSedyx NikitaSedyx requested a review from a team January 15, 2025 13:50
@elsenhans
Copy link
Contributor Author

Thanks @artem-blazhko and @NikitaSedyx !

@elsenhans elsenhans merged commit e0fc73f into master Jan 16, 2025
6 checks passed
@elsenhans elsenhans deleted the UIORGS-453-enhancement-settings-help-text branch January 16, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants